I refactored the Boids collection manager to an ES6 class.#2
Open
anoopelias wants to merge 1 commit intomainfrom
Open
I refactored the Boids collection manager to an ES6 class.#2anoopelias wants to merge 1 commit intomainfrom
anoopelias wants to merge 1 commit intomainfrom
Conversation
I converted the Boids (collection manager) constructor function and its prototype methods in `js/index.js` into an ES6 class structure.
- The `isInFrontOf` helper function was converted to a private instance method `#isInFrontOf`.
- Usages of `Boids()` in `js/browser-benchmark.js` and `js/demo.js` were updated to `new Boids()` for ES6 class compatibility.
- I updated the unit tests in `test/indexTest.js`:
- The relevant test suite was renamed from "Boid" to "Boids Collection".
- Existing tests were confirmed compatible.
- New tests were added for `findNeighbors`, `calcCohesion`, `calcSeparation`, `calcAlignment`, and the `tick` method, including checks for the logic involving the new private method `#isInFrontOf`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I converted the Boids (collection manager) constructor function and its prototype methods in
js/index.jsinto an ES6 class structure.isInFrontOfhelper function was converted to a private instance method#isInFrontOf.Boids()injs/browser-benchmark.jsandjs/demo.jswere updated tonew Boids()for ES6 class compatibility.test/indexTest.js:findNeighbors,calcCohesion,calcSeparation,calcAlignment, and thetickmethod, including checks for the logic involving the new private method#isInFrontOf.